Bug 201738

Summary: Link mediaDataLoadsAutomatically setting to AutoplayPolicy
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Jer Noble
Reported 2019-09-12 13:35:04 PDT
Link mediaDataLoadsAutomatically setting to AutoplayPolicy
Attachments
Patch (10.39 KB, patch)
2019-09-23 13:40 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.52 KB, patch)
2019-09-27 14:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (11.11 KB, patch)
2019-11-13 14:15 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-12 13:35:32 PDT
<rdar://problem/55315194>
Jer Noble
Comment 2 2019-09-23 13:40:40 PDT
Created attachment 379390 [details] Patch
Eric Carlson
Comment 3 2019-09-23 13:58:18 PDT
Comment on attachment 379390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379390&action=review > Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7 > + Nit: extra blank line. > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575 > + TestWebKitAPI::Util::run(&receivedLoadedEvent); Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here?
Jer Noble
Comment 4 2019-09-23 15:12:01 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 379390 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379390&action=review > > > Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7 > > + > > Nit: extra blank line. > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575 > > + TestWebKitAPI::Util::run(&receivedLoadedEvent); > > Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here? I don't really need one here; run(...) will spin until the value passed in turns true, so an explicit EXPECT_TRUE will be superfluous.
Jer Noble
Comment 5 2019-09-27 14:11:18 PDT
Created attachment 379764 [details] Patch for landing
Jer Noble
Comment 6 2019-11-13 14:15:02 PST
Created attachment 383497 [details] Patch
WebKit Commit Bot
Comment 7 2019-11-13 16:25:34 PST
Comment on attachment 383497 [details] Patch Clearing flags on attachment: 383497 Committed r252438: <https://trac.webkit.org/changeset/252438>
WebKit Commit Bot
Comment 8 2019-11-13 16:25:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.