Bug 201737 – Support observing a different set of view service state notifications in ApplicationStateTracker

• Component: WebKit2
• Status: RESOLVED FIXED

[David Quesada]

rdar://problem/54786414

[David Quesada]

Created attachment 378671 [details]
Patch

Patch. cq- for now since landing this is blocked by rdar://problem/55283266.

[Luming Yin]

Seems like rdar://problem/55283266 has been fixed.

[Chris Dumez]

Comment on attachment 378671 [details]
Patch

r=me. Fine as is but it may be nice to move the feature flag to Open Source if possible (or at least when it becomes possible).

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 378671 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 378671 [details]:

fast/hidpi/image-srcset-relative-svg-canvas-2x.html bug 206254 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 378671 [details]
Patch

Rejecting attachment 378671 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 378671, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=378671&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=201737&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 378671 from bug 201737.
Fetching: https://bugs.webkit.org/attachment.cgi?id=378671
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 536ffdbdeee090152e300dfc1ddc96aff294f0b7 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5b5c503b2acb2e3bf20b4d51dd075fc0135fb98a cc5558c0bcffce44e4852d45b3e94ccc97b73792 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 536ffdbdeee090152e300dfc1ddc96aff294f0b7 and refs/remotes/origin/master differ, using rebase:
:040000 040000 5b5c503b2acb2e3bf20b4d51dd075fc0135fb98a cc5558c0bcffce44e4852d45b3e94ccc97b73792 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   e2bfce4d354..98507e88155  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 255217 = e2bfce4d35471f34089935c059f890dd0eb57852
r255218 = a7bcdcd96e2ba1f3bed60fbe9939b2b65e776625
r255219 = 98507e8815531f046aa3612b9f617cadab0dd6c2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13312408

[David Quesada]

Created attachment 388956 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 388956 [details]
Patch for landing

Clearing flags on attachment: 388956

Committed r255222: <https://trac.webkit.org/changeset/255222>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

*** Bug 202399 has been marked as a duplicate of this bug. ***