Bug 201732

Summary: REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2019-09-12 12:19:38 PDT
Web Inspector: Layout Timeline View does not show popover for initiator data Steps to Reproduce: 1. Record a timeline with forced layouts 2. Show Detail Layout and Rendering timeline 3. Select a Forced Layout row => expected popover, but was none. Uncaught exception.
Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2019-09-12 12:20 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-12 12:20:05 PDT
<rdar://problem/55312339>
Joseph Pecoraro
Comment 2 2019-09-12 12:20:44 PDT
Created attachment 378666 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 3 2019-09-12 15:30:56 PDT
Comment on attachment 378666 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378666&action=review r=me, this is another example of why UI tests would be awesome, as well as another reason why I don't like `WI.DataGrid` :( > Source/WebInspectorUI/ChangeLog:3 > + REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data I think this was r243301.
WebKit Commit Bot
Comment 4 2019-09-13 12:03:06 PDT
Comment on attachment 378666 [details] [PATCH] Proposed Fix Clearing flags on attachment: 378666 Committed r249847: <https://trac.webkit.org/changeset/249847>
WebKit Commit Bot
Comment 5 2019-09-13 12:03:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.