| Summary: | wx port does not show tooltips | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kevin Watters <kevinwatters> | ||||||
| Component: | WebKit wx | Assignee: | Kevin Ollivier <kevino> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kevin Watters
2008-07-25 14:09:17 PDT
Created attachment 22481 [details]
implement ChromeClientWx::setToolTip
Implements ChromeClientWx::setToolTip and modifies wxWebView's mouse event handler to use EventHandler::mouseMoved instead of handleMouseMoveEvent.
Comment on attachment 22481 [details]
implement ChromeClientWx::setToolTip
Looks fine except for the tabs. WebCore uses 4 spaces, not tabs.
Also, which way is the easier conversion?
+ if (!tooltip || tooltip->GetTip() != wxString(tip))
+ m_webView->SetToolTip(tip);
From wxString to String or the other way? I'm surprised that you need the explicit wxString conversion there at all.
Since you don't have the ability to commit your own patches (yet), please upload a new patch without tabs.
Thanks!
Created attachment 22508 [details]
Revised tooltip support patch for the wx port.
Removed all the tabs.
Unfortunately, the explicit wxString conversion is necessary at the moment--the compiler complains about ambiguous overloads. Perhaps a future patch could resolve this.
|