Bug 201715

Summary: [JHBuild] Fix building gst-plugins-good against glibc 2.30
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: WebKitGTKAssignee: Patrick Griffis <pgriffis>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, ews-feeder
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Patrick Griffis
Reported 2019-09-11 22:23:10 PDT
[JHBuild] Fix building gst-plugins-good against glibc 2.30
Attachments
Patch (1.70 KB, patch)
2019-09-11 22:24 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Patch (3.07 KB, patch)
2019-09-11 22:27 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2019-09-11 22:24:42 PDT
Created attachment 378621 [details] Patch
Patrick Griffis
Comment 2 2019-09-11 22:27:05 PDT
Created attachment 378622 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2019-09-12 00:08:54 PDT
Comment on attachment 378622 [details] Patch I'm curious of the problem it tries to fix...
EWS
Comment 4 2019-09-12 12:43:17 PDT
Comment on attachment 378622 [details] Patch Rejecting attachment 378622 [details] from commit-queue. pgriffis@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Patrick Griffis
Comment 5 2019-09-12 13:02:45 PDT
(In reply to Xabier Rodríguez Calvar from comment #3) > Comment on attachment 378622 [details] > Patch > > I'm curious of the problem it tries to fix... You can see the upstream discussion, its discussed in the patch: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/635
WebKit Commit Bot
Comment 6 2019-09-13 01:11:16 PDT
Comment on attachment 378622 [details] Patch Clearing flags on attachment: 378622 Committed r249827: <https://trac.webkit.org/changeset/249827>
WebKit Commit Bot
Comment 7 2019-09-13 01:11:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.