Bug 201715 - [JHBuild] Fix building gst-plugins-good against glibc 2.30
Summary: [JHBuild] Fix building gst-plugins-good against glibc 2.30
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick Griffis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-11 22:23 PDT by Patrick Griffis
Modified: 2019-09-13 01:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2019-09-11 22:24 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Patch (3.07 KB, patch)
2019-09-11 22:27 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2019-09-11 22:23:10 PDT 
[JHBuild] Fix building gst-plugins-good against glibc 2.30
Comment 1 Patrick Griffis 2019-09-11 22:24:42 PDT 
Created attachment 378621 [details]
Patch
Comment 2 Patrick Griffis 2019-09-11 22:27:05 PDT 
Created attachment 378622 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2019-09-12 00:08:54 PDT 
Comment on attachment 378622 [details]
Patch

I'm curious of the problem it tries to fix...
Comment 4 EWS 2019-09-12 12:43:17 PDT 
Comment on attachment 378622 [details]
Patch

Rejecting attachment 378622 [details] from commit-queue.

pgriffis@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Patrick Griffis 2019-09-12 13:02:45 PDT 
(In reply to Xabier Rodríguez Calvar from comment #3)
> Comment on attachment 378622 [details]
> Patch
> 
> I'm curious of the problem it tries to fix...

You can see the upstream discussion, its discussed in the patch: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/635
Comment 6 WebKit Commit Bot 2019-09-13 01:11:16 PDT 
Comment on attachment 378622 [details]
Patch

Clearing flags on attachment: 378622

Committed r249827: <https://trac.webkit.org/changeset/249827>
Comment 7 WebKit Commit Bot 2019-09-13 01:11:18 PDT 
All reviewed patches have been landed.  Closing bug.