Bug 20170

Summary: [Qt] missing namespace defines in JavaScriptCore.pro
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed fix hausmann: review+

Gabor Loki
Reported 2008-07-25 06:50:02 PDT
With Qt-4.3.4 there is a build error. The QT_BEGIN_NAMESPACE and QT_END_NAMESPACE macros are never defined (rev. 35342). A similar patch is needed for JavaScriptCore.pro as http://trac.webkit.org/changeset/32306#file1 was.
Attachments
proposed fix (1.01 KB, patch)
2008-07-29 07:35 PDT, Csaba Osztrogonác 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2008-07-29 07:35:40 PDT
Created attachment 22538 [details] proposed fix
Simon Hausmann
Comment 2 2008-07-31 06:00:01 PDT
Comment on attachment 22538 [details] proposed fix Thanks for the fix!
Simon Hausmann
Comment 3 2008-07-31 08:01:02 PDT
Landed in r35479
Note You need to log in before you can comment on or make changes to this bug.