Bug 201682

Summary: Use typed identifiers for IDB connection identifiers
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, commit-queue, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2019-09-11 02:51:30 PDT
Use typed identifiers for IDB connection identifiers
Attachments
Patch (25.29 KB, patch)
2019-09-11 02:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.34 KB, patch)
2019-09-12 00:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-09-11 02:54:02 PDT
Created attachment 378550 [details] Patch
Chris Dumez
Comment 2 2019-09-11 08:22:02 PDT
Comment on attachment 378550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378550&action=review r=me with comments. > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp:114 > + ASSERT(m_serverConnectionIdentifier.toUInt64()); This change should not be needed. > Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp:92 > + return IDBResourceIdentifier(IDBConnectionIdentifier { WTF::HashTableDeletedValue}, std::numeric_limits<uint64_t>::max()); Missing space before } > Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h:46 > +using IDBConnectionIdentifier = ObjectIdentifier<IDBConnectionIdentifierType>; Why isn't this simply using IDBConnectionIdentifier = ProcessIdentifier; ? > Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp:97 > + return makeObjectIdentifier<IDBConnectionIdentifierType>(1); Could this be a valid ProcessIdentifier instead (e.g. the current process' identifier?)
youenn fablet
Comment 3 2019-09-12 00:39:35 PDT
Created attachment 378630 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-09-12 01:47:38 PDT
Comment on attachment 378630 [details] Patch for landing Clearing flags on attachment: 378630 Committed r249803: <https://trac.webkit.org/changeset/249803>
WebKit Commit Bot
Comment 5 2019-09-12 01:47:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-12 01:48:19 PDT
<rdar://problem/55294547>
Radar WebKit Bug Importer
Comment 7 2019-09-12 01:48:20 PDT
<rdar://problem/55294548>
Note You need to log in before you can comment on or make changes to this bug.