Bug 201672

Summary:

[WHLSL] Remove null from the standard library

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

WebGPU

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Saam Barati

Reported 2019-09-10 18:31:06 PDT

...

Attachments
patch (226.82 KB, patch) 2019-09-11 15:53 PDT, Saam Barati	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2019-09-10 20:59:51 PDT

I did this in my "remove getters/setters/anders patch", but reverted and rebuilt the standard library since I made mistakes with matrices. When I did that, I forgot to remove 'null' again. Should be trivial to fix

Saam Barati

Comment 2 2019-09-11 15:53:26 PDT

Created attachment 378589 [details] patch

Robin Morisset

Comment 3 2019-09-11 17:36:56 PDT

Comment on attachment 378589 [details] patch r=me

WebKit Commit Bot

Comment 4 2019-09-11 22:29:09 PDT

Comment on attachment 378589 [details] patch Clearing flags on attachment: 378589 Committed r249794: <https://trac.webkit.org/changeset/249794>

WebKit Commit Bot

Comment 5 2019-09-11 22:29:10 PDT

All reviewed patches have been landed. Closing bug.