Bug 201672 - [WHLSL] Remove null from the standard library
Summary: [WHLSL] Remove null from the standard library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-10 18:31 PDT by Saam Barati
Modified: 2019-09-11 22:30 PDT (History)
9 users (show)

See Also:

Attachments
patch (226.82 KB, patch)
2019-09-11 15:53 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-09-10 18:31:06 PDT 
...
Comment 1 Saam Barati 2019-09-10 20:59:51 PDT 
I did this in my "remove getters/setters/anders patch", but reverted and rebuilt the standard library since I made mistakes with matrices. When I did that, I forgot to remove 'null' again. Should be trivial to fix
Comment 2 Saam Barati 2019-09-11 15:53:26 PDT 
Created attachment 378589 [details]
patch
Comment 3 Robin Morisset 2019-09-11 17:36:56 PDT 
Comment on attachment 378589 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2019-09-11 22:29:09 PDT 
Comment on attachment 378589 [details]
patch

Clearing flags on attachment: 378589

Committed r249794: <https://trac.webkit.org/changeset/249794>
Comment 5 WebKit Commit Bot 2019-09-11 22:29:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-11 22:30:17 PDT 
<rdar://problem/55290770>
Comment 7 Radar WebKit Bug Importer 2019-09-11 22:30:19 PDT 
<rdar://problem/55290771>