Bug 201617

Summary: [macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2019-09-09 15:36:53 PDT
The commit <https://trac.webkit.org/changeset/249649> introduced a layering violation in AuxiliaryProcessProxy::didFinishLaunching. This can be fixed by creating a virtual method in AuxiliaryProcessProxy and override the method in the WebProcessProxy to do the work.
Comment 1 Per Arne Vollan 2019-10-04 13:40:01 PDT
Created attachment 380249 [details]
Patch
Comment 2 Brent Fulgham 2019-10-04 15:51:43 PDT
Comment on attachment 380249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380249&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:332
> +    bool shouldSendPendingMessage(const PendingMessage&) override;

final?
Comment 3 Per Arne Vollan 2019-10-07 13:43:45 PDT
Created attachment 380354 [details]
Patch
Comment 4 Per Arne Vollan 2019-10-07 13:54:59 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 380249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380249&action=review
> 
> > Source/WebKit/UIProcess/WebProcessProxy.h:332
> > +    bool shouldSendPendingMessage(const PendingMessage&) override;
> 
> final?

Yes! Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2019-10-07 15:14:53 PDT
Comment on attachment 380354 [details]
Patch

Clearing flags on attachment: 380354

Committed r250799: <https://trac.webkit.org/changeset/250799>
Comment 6 Radar WebKit Bug Importer 2019-10-16 14:46:15 PDT
<rdar://problem/56347784>