Bug 201617

Summary: [macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported 2019-09-09 15:36:53 PDT
The commit <https://trac.webkit.org/changeset/249649> introduced a layering violation in AuxiliaryProcessProxy::didFinishLaunching. This can be fixed by creating a virtual method in AuxiliaryProcessProxy and override the method in the WebProcessProxy to do the work.
Attachments
Patch (7.56 KB, patch)
2019-10-04 13:40 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (7.56 KB, patch)
2019-10-07 13:43 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-10-04 13:40:01 PDT
Created attachment 380249 [details] Patch
Brent Fulgham
Comment 2 2019-10-04 15:51:43 PDT
Comment on attachment 380249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380249&action=review > Source/WebKit/UIProcess/WebProcessProxy.h:332 > + bool shouldSendPendingMessage(const PendingMessage&) override; final?
Per Arne Vollan
Comment 3 2019-10-07 13:43:45 PDT
Created attachment 380354 [details] Patch
Per Arne Vollan
Comment 4 2019-10-07 13:54:59 PDT
(In reply to Brent Fulgham from comment #2) > Comment on attachment 380249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380249&action=review > > > Source/WebKit/UIProcess/WebProcessProxy.h:332 > > + bool shouldSendPendingMessage(const PendingMessage&) override; > > final? Yes! Thanks for reviewing :)
WebKit Commit Bot
Comment 5 2019-10-07 15:14:53 PDT
Comment on attachment 380354 [details] Patch Clearing flags on attachment: 380354 Committed r250799: <https://trac.webkit.org/changeset/250799>
Radar WebKit Bug Importer
Comment 6 2019-10-16 14:46:15 PDT
<rdar://problem/56347784>
Note You need to log in before you can comment on or make changes to this bug.