Bug 201572

Summary: [FTW] Minor cleanups to avoid crashes during web browsing
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, don.olmstead, fujii.hironori, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2019-09-06 20:17:36 PDT
This patch addresses two crashes seen when doing general web browsing on Amazon.com and Apple.com using the FTW build of WebKit: 1. ImageBuffer::sinkIntoImage was attempting to use a render target after WTFMoving it elsewhere. 2. ImageBuffer::copyNativeImage was not properly checking the type of the render target to make sure it was suitable for Bitmap operations. 3. BackingStoreBackendDirect2DImpl::scroll would crash if the scroll offset was outside the bounds of the current view. In that case, it would attempt to allocate a texture of zero size, which triggered a crash.
Attachments
Patch (4.06 KB, patch)
2019-09-06 20:22 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-09-06 20:22:59 PDT
Created attachment 378268 [details] Patch
Brent Fulgham
Comment 2 2019-09-06 22:17:30 PDT
Thank you for the review, ap!
WebKit Commit Bot
Comment 3 2019-09-06 22:59:45 PDT
Comment on attachment 378268 [details] Patch Clearing flags on attachment: 378268 Committed r249609: <https://trac.webkit.org/changeset/249609>
WebKit Commit Bot
Comment 4 2019-09-06 22:59:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-09-06 23:01:04 PDT
<rdar://problem/55140532>
Note You need to log in before you can comment on or make changes to this bug.