Bug 20156

Summary: [Qt] build failure after r35293
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed fix eric: review-

Gabor Loki
Reported 2008-07-24 05:14:08 PDT
I have a build failures after r35291 and r35293 on qt-linux. The fail at r35291 comes from http://trac.webkit.org/changeset/35291/trunk/JavaScriptCore/kjs/ArgList.h change where operator[] method was removed. The other fail at r35293 comes from http://trac.webkit.org/changeset/35293#file6 where a new include file (JSClassRef.h) was added to JSGlobalData.cpp.
Attachments
proposed fix (6.22 KB, patch)
2008-07-24 05:21 PDT, Gabor Loki 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2008-07-24 05:21:35 PDT
Created attachment 22461 [details] proposed fix The attached patch could fix the bug on qt-linux. I have also checked the gtk-port on linux, and it seems OK. I cannot able to test it on a Mac.
Eric Seidel (no email)
Comment 2 2008-07-24 16:02:25 PDT
Comment on attachment 22461 [details] proposed fix Can't do that: -#include <JavaScriptCore/JSBase.h> -#include <JavaScriptCore/JSValueRef.h> +#include "JSBase.h" +#include "JSValueRef.h" You'll have to use some sort of ForwardingHeaders solution on linux. See JavaScriptCore/ForwardingHeaders or WebCore/ForwardingHeaders
Eric Seidel (no email)
Comment 3 2008-07-24 16:02:45 PDT
Comment on attachment 22461 [details] proposed fix The API directory contains headers which Apple ships as API, in general we can't change those.
Gabor Loki
Comment 4 2008-07-25 05:33:28 PDT
It seems that the http://trac.webkit.org/changeset/35335 patch fixed the problem.
Note You need to log in before you can comment on or make changes to this bug.