Bug 201559

Summary: Web Inspector: CSS Formatter: links to CSS resources don't map to the right line after pretty printing if the line is after a multiline comment
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-09-06 14:04:17 PDT
Newlines in multiline comments weren't added as line endings, so they weren't considered when a source code location updated after pretty printing.
Attachments
Patch (2.33 KB, patch)
2019-09-06 14:09 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-09-06 14:09:14 PDT
Created attachment 378234 [details] Patch
Joseph Pecoraro
Comment 2 2019-09-06 14:20:44 PDT
Comment on attachment 378234 [details] Patch r=me
Joseph Pecoraro
Comment 3 2019-09-06 14:21:00 PDT
We should consider some way of testing this. I may look into it for the HTML formatter.
WebKit Commit Bot
Comment 4 2019-09-06 15:34:10 PDT
Comment on attachment 378234 [details] Patch Clearing flags on attachment: 378234 Committed r249596: <https://trac.webkit.org/changeset/249596>
WebKit Commit Bot
Comment 5 2019-09-06 15:34:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-06 15:35:22 PDT
<rdar://problem/55130685>
Note You need to log in before you can comment on or make changes to this bug.