Bug 201554

Summary: [LFC] A formatting context root is always a containing block for relative: static boxes.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Comment 1 Radar WebKit Bug Importer 2019-09-06 12:44:07 PDT
<rdar://problem/55123295>
Comment 2 zalan 2019-09-06 12:46:40 PDT
Created attachment 378219 [details]
Patch
Comment 3 Antti Koivisto 2019-09-06 12:51:17 PDT
Comment on attachment 378219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378219&action=review

> Source/WebCore/layout/layouttree/LayoutBox.cpp:191
> +    // content edge of the nearest block container ancestor box or which establishes a formatting context.

Recent spec change?
Comment 4 zalan 2019-09-06 12:54:07 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 378219 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378219&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutBox.cpp:191
> > +    // content edge of the nearest block container ancestor box or which establishes a formatting context.
> 
> Recent spec change?
Not really. Back then my screen had some dead pixels and I must have missed that last part of the sentence.
Comment 5 Antti Koivisto 2019-09-06 12:56:38 PDT
> Not really. Back then my screen had some dead pixels and I must have missed
> that last part of the sentence.

Try moving the window around.
Comment 6 WebKit Commit Bot 2019-09-06 13:50:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 378219 [details]:

media/remote-control-command-seek.html bug 192381 (authors: eric.carlson@apple.com and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-09-06 13:51:27 PDT
Comment on attachment 378219 [details]
Patch

Clearing flags on attachment: 378219

Committed r249590: <https://trac.webkit.org/changeset/249590>
Comment 8 WebKit Commit Bot 2019-09-06 13:51:29 PDT
All reviewed patches have been landed.  Closing bug.