Bug 201538

Summary: Web Inspector: Network: Error response headers summary has wrong color border
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2019-09-06 01:34:51 PDT
Network: Error response headers summary has wrong color border Steps to Reproduce: 1. Inspect <http://example.com> 2. js> fetch("test") 3. Show Network tab 4. Select "test" request 5. Show Headers pane => summary section has green border but red text Notes • `body[dir] .resource-details > section.error > .details` gets overridden by • `body[dir] .resource-headers > section.summary > .details` which comes later in CSS Lets make resource-headers re-apply the error case to avoid additional specificity issues.
Attachments
[PATCH] Proposed Fix (1.51 KB, patch)
2019-09-06 01:36 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (516.65 KB, image/png)
2019-09-06 01:36 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (516.62 KB, image/png)
2019-09-06 01:37 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-06 01:35:12 PDT
<rdar://problem/55104469>
Joseph Pecoraro
Comment 2 2019-09-06 01:36:11 PDT
Created attachment 378167 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2019-09-06 01:36:39 PDT
Created attachment 378168 [details] [IMAGE] Before
Joseph Pecoraro
Comment 4 2019-09-06 01:37:00 PDT
Created attachment 378169 [details] [IMAGE] After
Devin Rousso
Comment 5 2019-09-06 01:44:10 PDT
Comment on attachment 378167 [details] [PATCH] Proposed Fix rs=me
WebKit Commit Bot
Comment 6 2019-09-06 02:15:03 PDT
Comment on attachment 378167 [details] [PATCH] Proposed Fix Clearing flags on attachment: 378167 Committed r249570: <https://trac.webkit.org/changeset/249570>
WebKit Commit Bot
Comment 7 2019-09-06 02:15:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.