Bug 201494
| Summary: | Comment in isSystemFont() no longer matches code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | ahmad.saleem792, rniwa, webkit-bug-importer |
| Priority: | P5 | Keywords: | EasyFix, InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=199975 | ||
Daniel Bates
Following <https://trac.webkit.org/changeset/247720/webkit> comment in <https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp?rev=249040#L795> no longer matches the code:
[[
static inline bool isSystemFont(const String& family)
{
// AtomString's operator[] handles out-of-bounds by returning 0.
return family[0] == '.';
}
]]
Following r247720 function takes a String. Comment talks about AtomString.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Oh oops, we should probably update the comment.
Ahmad Saleem
We still have following comment:
https://github.com/WebKit/WebKit/blob/e93103f1a03a7acfe0b99029948079eeba36f059/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp#L222
// AtomString's operator[] handles out-of-bounds by returning 0.
is to change?
// String's operator[] handles out-of-bounds by returning 0.
Happy to do unreviewed PR to change to above.
Ryosuke Niwa
FWIW, we should probably go through a code review.
EWS
Committed 269787@main (8e1a9a0da3d1): <https://commits.webkit.org/269787@main>
Reviewed commits have been landed. Closing PR #19566 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/117498827>