Bug 201488

Summary:

[JSC] Promise resolve/reject functions should be created more efficiently

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

198849

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	mark.lam: review+

Yusuke Suzuki

Reported 2019-09-04 19:57:38 PDT

...

Attachments
Patch (12.55 KB, patch) 2019-09-09 03:40 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (12.57 KB, patch) 2019-09-09 03:43 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (14.13 KB, patch) 2019-09-09 04:01 PDT, Yusuke Suzuki	mark.lam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2019-09-04 20:00:02 PDT

bug 198849 fixes the critical issue, but it makes @resolve / @reject function creation more costly. And we know that this causes 7-8% regression in JetStream2/async-fs. We should have a good mechanism to produce such a function without allocating FunctionRareData so that we can recover async-fs regression.

Radar WebKit Bug Importer

Comment 2 2019-09-04 20:00:22 PDT

<rdar://problem/55052212>

Yusuke Suzuki

Comment 3 2019-09-09 03:40:07 PDT

Created attachment 378360 [details] Patch

Yusuke Suzuki

Comment 4 2019-09-09 03:43:00 PDT

Created attachment 378361 [details] Patch

Yusuke Suzuki

Comment 5 2019-09-09 04:01:28 PDT

Created attachment 378363 [details] Patch