Bug 201478

Summary: REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: WebGPUAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, justin_fan, mmaxfield, repstein, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201123
https://bugs.webkit.org/show_bug.cgi?id=201425
https://bugs.webkit.org/show_bug.cgi?id=199275
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Said Abou-Hallawa 2019-09-04 16:26:14 PDT
This layout test is failing consistently on macOS Catalina after <https://trac.webkit.org/changeset/249460>.
Comment 1 Said Abou-Hallawa 2019-09-04 16:34:06 PDT
Created attachment 378026 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-09-04 16:41:39 PDT
I just learnt that webgpu layout tests are disabled on macOS High Sierra. And this is why I did not see this failure before landing r249460.

This time I made sure all webgpu layout tests are passing with this change.
Comment 3 Russell Epstein 2019-09-05 11:02:15 PDT
Given Said's local testing, this patch looks ready for landing. Reviewers, can you confirm?
Comment 4 Simon Fraser (smfr) 2019-09-05 11:11:47 PDT
Comment on attachment 378026 [details]
Patch

Maybe the resource should just be re-encoded without the EXIF rotation.
Comment 5 Said Abou-Hallawa 2019-09-05 11:28:26 PDT
Created attachment 378101 [details]
Patch
Comment 6 Said Abou-Hallawa 2019-09-05 11:33:16 PDT
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 378026 [details]
> Patch
> 
> Maybe the resource should just be re-encoded without the EXIF rotation.

I changed the ChangeLog to have the correct description of the fix. Now we want to match the drawing of drawGreenAndBlueCheckerboardInSoftware() which was changed in r249460.

I think also it is good that we have to deal with issues which the developers have to deal with after r249364 and maybe they do not have the option to change the orientation of the images.
Comment 7 Said Abou-Hallawa 2019-09-05 13:05:03 PDT
Created attachment 378107 [details]
Patch
Comment 8 Said Abou-Hallawa 2019-09-05 13:13:56 PDT
Created attachment 378108 [details]
Patch
Comment 9 Said Abou-Hallawa 2019-09-05 13:24:41 PDT
Created attachment 378110 [details]
Patch
Comment 10 WebKit Commit Bot 2019-09-10 13:37:08 PDT
Comment on attachment 378110 [details]
Patch

Clearing flags on attachment: 378110

Committed r249732: <https://trac.webkit.org/changeset/249732>
Comment 11 WebKit Commit Bot 2019-09-10 13:37:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-09-10 13:38:18 PDT
<rdar://problem/55234788>