Bug 201477

Summary: Replace defaultCustomPasteboardDataEnabled by an equivalent macro
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup wenson_hsieh: review+

Ryosuke Niwa
Reported 2019-09-04 16:07:04 PDT
https://trac.webkit.org/changeset/227282 introduced defaultCustomPasteboardDataEnabled() to disable the custom pasteboard data on iOS and macOS apps linked against old SDKs. However, this had a bug that the check inside WebContent would always return true. Because WebPreferences values aren't propagated from UI process to WebContent process unless there is a value change, it meant that custom pasteboard data is always enabled. Replace this function with a simple macro which always enables the custom pasteboard data on iOS and macOS.
Attachments
Cleanup (3.62 KB, patch)
2019-09-04 16:11 PDT, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-09-04 16:11:11 PDT
Created attachment 378024 [details] Cleanup
Ryosuke Niwa
Comment 2 2019-09-04 19:11:24 PDT
Committed r249512: <https://trac.webkit.org/changeset/249512>
Radar WebKit Bug Importer
Comment 3 2019-09-04 19:12:17 PDT
<rdar://problem/55050818>
Note You need to log in before you can comment on or make changes to this bug.