Bug 201473

Summary: Deprecate all WKCookieManagerRef functions
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2019-09-04 15:29:18 PDT
Deprecate all WKCookieManagerRef functions
Attachments
Patch (9.69 KB, patch)
2019-09-04 15:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.66 KB, patch)
2019-09-04 18:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.68 KB, patch)
2019-09-04 19:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.17 KB, patch)
2019-09-05 08:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.20 KB, patch)
2019-09-05 08:44 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.22 KB, patch)
2019-09-05 16:51 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.23 KB, patch)
2019-09-05 17:18 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-09-04 15:33:16 PDT
Created attachment 378018 [details] Patch
Alex Christensen
Comment 2 2019-09-04 17:04:31 PDT
Comment on attachment 378018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378018&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:146 > +WK_EXPORT WKCookieManagerRef WKContextGetCookieManager(WKContextRef context) WK_C_API_DEPRECATED; This is still used in a few tests :( I'll replace it.
Alex Christensen
Comment 3 2019-09-04 18:36:54 PDT
Created attachment 378034 [details] Patch
Alex Christensen
Comment 4 2019-09-04 19:29:38 PDT
Created attachment 378037 [details] Patch
Alex Christensen
Comment 5 2019-09-05 08:24:41 PDT
Created attachment 378084 [details] Patch
Alex Christensen
Comment 6 2019-09-05 08:44:36 PDT
Created attachment 378086 [details] Patch
Alex Christensen
Comment 7 2019-09-05 16:51:49 PDT
Created attachment 378137 [details] Patch
Alex Christensen
Comment 8 2019-09-05 17:18:50 PDT
Created attachment 378140 [details] Patch
Alex Christensen
Comment 9 2019-09-06 08:52:03 PDT
I'll add my new header to WebKit_PUBLIC_FRAMEWORK_HEADERS in PlatformWin.cmake before landing to fix the WinCairo build.
Alex Christensen
Comment 10 2019-09-06 13:42:55 PDT
http://trac.webkit.org/r249589
Radar WebKit Bug Importer
Comment 11 2019-09-06 13:43:29 PDT
<rdar://problem/55125643>
Note You need to log in before you can comment on or make changes to this bug.