Bug 201468

Summary: Remove unused SPI that accesses MemoryCache directly
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, ryanhaddad, thorton, webkit-bug-importer, wenson_hsieh, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Alex Christensen
Reported 2019-09-04 12:58:34 PDT
Remove unused SPI that accesses MemoryCache directly
Attachments
Patch (7.05 KB, patch)
2019-09-04 13:04 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Patch (7.25 KB, patch)
2019-09-04 22:26 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-09-04 13:04:41 PDT
Created attachment 378004 [details] Patch
Alex Christensen
Comment 2 2019-09-04 14:11:20 PDT
http://trac.webkit.org/r249498
Radar WebKit Bug Importer
Comment 3 2019-09-04 14:12:20 PDT
<rdar://problem/55037063>
Wenson Hsieh
Comment 4 2019-09-04 20:59:07 PDT
Should we delete the API test WebKitLegacy.MemoryCacheAddImageToCache as well?
Ryosuke Niwa
Comment 5 2019-09-04 22:22:04 PDT
Yeah, this broke iOS build :(
Ryosuke Niwa
Comment 6 2019-09-04 22:26:21 PDT
Reopening to attach new patch.
Ryosuke Niwa
Comment 7 2019-09-04 22:26:22 PDT
Created attachment 378046 [details] Patch
Ryosuke Niwa
Comment 8 2019-09-04 22:26:58 PDT
Please whoever wake up first / stay up late view & land this patch to fix iOS builds.
WebKit Commit Bot
Comment 9 2019-09-05 00:47:28 PDT
Comment on attachment 378046 [details] Patch Clearing flags on attachment: 378046 Committed r249525: <https://trac.webkit.org/changeset/249525>
Alex Christensen
Comment 10 2019-09-06 10:15:54 PDT
Sorry about that. Thanks for the fix.
Note You need to log in before you can comment on or make changes to this bug.