Bug 201464

Summary: [LFC] Assert on FormattingContext escaping
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2019-09-04 11:31:51 PDT 
We should not need to read display boxes in different formatting contexts apart from a few (justified) cases.
Comment 1 Radar WebKit Bug Importer 2019-09-04 11:32:14 PDT 
<rdar://problem/55029574>
Comment 2 zalan 2019-09-04 11:40:15 PDT 
Created attachment 377992 [details]
Patch
Comment 3 Antti Koivisto 2019-09-04 11:44:19 PDT 
Comment on attachment 377992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377992&action=review

> Source/WebCore/layout/FormattingContext.h:72
> +    enum class EscapeType { AccesChildFormattingContext, AccessParentFormattingContext, AccessAncestorFormattingContext };

Typo "Acces"

Maybe split this into lines?
Comment 4 zalan 2019-09-04 11:48:34 PDT 
Created attachment 377994 [details]
Patch
Comment 5 zalan 2019-09-04 12:58:49 PDT 
Created attachment 378002 [details]
Patch
Comment 6 WebKit Commit Bot 2019-09-04 13:42:15 PDT 
Comment on attachment 378002 [details]
Patch

Clearing flags on attachment: 378002

Committed r249497: <https://trac.webkit.org/changeset/249497>
Comment 7 WebKit Commit Bot 2019-09-04 13:42:17 PDT 
All reviewed patches have been landed.  Closing bug.