Bug 201434 – [GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Pablo Saavedra]

```
../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:179:9: error: ‘GstGLSyncMeta’ was not declared in this scope
         GstGLSyncMeta* meta = gst_buffer_get_gl_sync_meta(m_buffer);
         ^~~~~~~~~~~~~
..```

[Pablo Saavedra]

Created attachment 377918 [details]
patch

[Pablo Saavedra]

The current patch fix the build but maybe the right patch for this case also it should restore the logic replaced by r249427 in L719:

```
719            GLuint textureID = frameHolder->textureID();
720	 	            std::unique_ptr<TextureMapperPlatformLayerBuffer> layerBuffer;
721	 	            if (textureID) {
722	 	                layerBuffer = makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA);
```

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719

[Pablo Saavedra]

(In reply to Pablo Saavedra from comment #2)
> The current patch fix the build but maybe the right patch for this case also
> it should restore the logic replaced by r249427 in L719:
> 
> ```
> 719            GLuint textureID = frameHolder->textureID();
> 720	 	            std::unique_ptr<TextureMapperPlatformLayerBuffer>
> layerBuffer;
> 721	 	            if (textureID) {
> 722	 	                layerBuffer =
> makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(),
> frameHolder->flags(), GraphicsContext3D::RGBA);
> ```
> 
> https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/
> graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719

Nah,  only is invoked in sections of the code already safeguarded by `#if USE(GSTREAMER_GL)`

[Pablo Saavedra]

Created attachment 377957 [details]
patch

[WebKit Commit Bot]

Comment on attachment 377957 [details]
patch

Clearing flags on attachment: 377957

Committed r249474: <https://trac.webkit.org/changeset/249474>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55010966>