Summary: | [GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pablo Saavedra <psaavedra> | ||||||
Component: | WebCore Misc. | Assignee: | Pablo Saavedra <psaavedra> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue, pnormand, sabouhallawa, simon.fraser, webkit-bug-importer, zan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Pablo Saavedra
2019-09-03 13:49:49 PDT
Created attachment 377918 [details]
patch
The current patch fix the build but maybe the right patch for this case also it should restore the logic replaced by r249427 in L719: ``` 719 GLuint textureID = frameHolder->textureID(); 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> layerBuffer; 721 if (textureID) { 722 layerBuffer = makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA); ``` https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719 (In reply to Pablo Saavedra from comment #2) > The current patch fix the build but maybe the right patch for this case also > it should restore the logic replaced by r249427 in L719: > > ``` > 719 GLuint textureID = frameHolder->textureID(); > 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> > layerBuffer; > 721 if (textureID) { > 722 layerBuffer = > makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), > frameHolder->flags(), GraphicsContext3D::RGBA); > ``` > > https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/ > graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719 Nah, only is invoked in sections of the code already safeguarded by `#if USE(GSTREAMER_GL)` Created attachment 377957 [details]
patch
Comment on attachment 377957 [details] patch Clearing flags on attachment: 377957 Committed r249474: <https://trac.webkit.org/changeset/249474> All reviewed patches have been landed. Closing bug. |