Bug 201426

Summary: Allow run-jsc-stress-tests still run if some of the remote hosts are not available
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: REOPENED    
Severity: Normal CC: aakash_jain, guijemont, jbedard, mark.lam, pmatos, saam, webkit-bug-importer, ysuzuki, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 213097    
Bug Blocks:    
Attachments:
Description Flags
WIP - Test
none
Patch
none
Patch none

Caio Lima
Reported 2019-09-03 09:48:22 PDT
Now, if one of the listed remote hosts is not available, we will abort the run of the script. This is a problem mainly to ARMv7 and MIPS EWS, because we run tests in multiple devices, and if any of the bots are unavailable, we don't process any patch in the queue. Keeping this script executing if we have at least 1 remote host available will increase the robustness of those EWS bots.
Attachments
WIP - Test (3.24 KB, patch)
2019-09-03 09:49 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2019-09-03 12:42 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (4.62 KB, patch)
2020-06-02 05:50 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2019-09-03 09:49:35 PDT
Created attachment 377901 [details] WIP - Test
Caio Lima
Comment 2 2019-09-03 12:42:41 PDT
Created attachment 377914 [details] Patch
Guillaume Emont
Comment 3 2019-09-24 10:45:09 PDT
Comment on attachment 377914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377914&action=review The change looks good to me. It gives me loads of ideas of things to clean up in that script (such as having a function with fewer parameters to replace all the mysys("ssh", ....) calls), but that's beside the point. > Tools/ChangeLog:3 > + Allow run-jsc-stress-tests still run if some of the remote hosts are not available grammar/clarity nitpick: Allow run-jsc-stress-tests to keep on running if some of the remote hosts are not available
Paulo Matos
Comment 4 2019-09-25 02:06:52 PDT
Took a look at it as well, and besides Guillaume's nit, I have nothing to add. This is a very useful patch.
Caio Lima
Comment 5 2020-06-02 05:50:37 PDT
Created attachment 400808 [details] Patch
Caio Lima
Comment 6 2020-06-05 05:25:23 PDT
Ping Review. We are particularly interested into this patch because of our constant issues into MIPS EWS queue. The current hardware we have there is very faulty and we are using a dozen of them to run tests faster. Being able to keep consuming queue items if 1 or 2 boards are temporarily unavailable would be great to avoid skipping a lot of important patches. We already started looking for alternative MIPS hardware, but in the meantime, this patch can benefit a lot MIPS EWS queue wait time.
Saam Barati
Comment 7 2020-06-05 11:26:09 PDT
Comment on attachment 400808 [details] Patch r=me
Caio Lima
Comment 8 2020-06-07 07:11:10 PDT
Comment on attachment 400808 [details] Patch Thank you very much for the review!
EWS
Comment 9 2020-06-07 07:35:56 PDT
Committed r262696: <https://trac.webkit.org/changeset/262696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400808 [details].
Radar WebKit Bug Importer
Comment 10 2020-06-07 07:36:19 PDT
<rdar://problem/64089436>
Yusuke Suzuki
Comment 11 2020-06-11 15:29:37 PDT
Re-opened since this is blocked by bug 213097
Note You need to log in before you can comment on or make changes to this bug.