| Summary: | results.webkit.org: Increase default limit for LimitSlider | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, webkit-bug-importer, zhifei_fang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2019-09-03 09:18:52 PDT
Created attachment 377899 [details]
Patch
Comment on attachment 377899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377899&action=review > Tools/ChangeLog:3 > + results.webkit.org: Increase default size Bug title should be more descriptive. > Tools/ChangeLog:9 > + (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic. why linear now? Typo: liner. > Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170 > const maxRange = 1000; this variable seems unused after this change. (In reply to Aakash Jain from comment #2) > Comment on attachment 377899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377899&action=review > > > Tools/ChangeLog:3 > > + results.webkit.org: Increase default size > > Bug title should be more descriptive. > > > Tools/ChangeLog:9 > > + (LimitSlider): Increase the default limit, make limit slider liner instead of logarithmic. > > why linear now? The logarithmic slider was not popular with the bot watchers, they pretty universally said it was strange to use. > > Typo: liner. > > > Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js:170 > > const maxRange = 1000; > > this variable seems unused after this change. Created attachment 377904 [details]
Patch
Comment on attachment 377904 [details] Patch Clearing flags on attachment: 377904 Committed r249432: <https://trac.webkit.org/changeset/249432> All reviewed patches have been landed. Closing bug. |