Bug 201415

Summary: [WPE] Make view backends multi-view-friendly
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Zan Dobersek 2019-09-02 23:20:35 PDT
[WPE] Make view backends multi-view-friendly
Comment 1 Zan Dobersek 2019-09-02 23:27:20 PDT
Created attachment 377871 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-09-03 01:15:05 PDT
Comment on attachment 377871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377871&action=review

> Tools/ChangeLog:7
> +

Could you explain here why the changes make view backends multi-view-friendly? Looking at the patch it seems just a refactoring to move the code to initialize EGL.

> Tools/wpe/backends/HeadlessViewBackend.cpp:61
> +                if (!eglInitialize(eglDisplay, nullptr, nullptr))

Don't we need to do the eglBindAPI here too?
Comment 3 Zan Dobersek 2019-09-03 03:43:40 PDT
Created attachment 377885 [details]
Patch for landing
Comment 4 Zan Dobersek 2019-09-03 03:45:48 PDT
Comment on attachment 377885 [details]
Patch for landing

Clearing flags on attachment: 377885

Committed r249424: <https://trac.webkit.org/changeset/249424>
Comment 5 Zan Dobersek 2019-09-03 03:45:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-03 03:46:18 PDT
<rdar://problem/54970698>