Bug 201413

Summary: Remove the need to pass performJITMemcpy as a pointer.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch.
msaboff: review+
patch for landing.
none
patch for landing.
none
patch for landing.
none
patch for landing.
none
patch for landing w/ more speculative non-darwin build fixes. none

Mark Lam
Reported 2019-09-02 19:15:23 PDT
We can always use a direct branch.
Attachments
proposed patch. (28.45 KB, patch)
2019-09-02 19:18 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (29.15 KB, patch)
2019-09-03 08:14 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing. (29.25 KB, patch)
2019-09-03 10:03 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing. (31.57 KB, patch)
2019-09-03 12:20 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing. (31.58 KB, patch)
2019-09-03 13:08 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing. (31.59 KB, patch)
2019-09-03 13:40 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing w/ more speculative non-darwin build fixes. (32.03 KB, patch)
2019-09-03 15:03 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-09-02 19:15:44 PDT
I meant, we can always use a direct call.
Mark Lam
Comment 2 2019-09-02 19:18:29 PDT
Created attachment 377868 [details] proposed patch.
Radar WebKit Bug Importer
Comment 3 2019-09-02 19:18:53 PDT
<rdar://problem/54961451>
Mark Lam
Comment 4 2019-09-03 08:10:01 PDT
(In reply to Mark Lam from comment #1) > I meant, we can always use a direct call. Actually, we want performJITMemcpy to always be inlined.
Mark Lam
Comment 5 2019-09-03 08:14:10 PDT
Created attachment 377896 [details] proposed patch.
Michael Saboff
Comment 6 2019-09-03 08:32:21 PDT
Comment on attachment 377896 [details] proposed patch. r=me
Mark Lam
Comment 7 2019-09-03 10:03:17 PDT
Created attachment 377902 [details] patch for landing. Thanks for the review.
Mark Lam
Comment 8 2019-09-03 12:20:32 PDT
Created attachment 377912 [details] patch for landing.
Mark Lam
Comment 9 2019-09-03 13:08:03 PDT
Created attachment 377915 [details] patch for landing.
Mark Lam
Comment 10 2019-09-03 13:40:20 PDT
Created attachment 377917 [details] patch for landing.
Mark Lam
Comment 11 2019-09-03 15:03:20 PDT
Created attachment 377925 [details] patch for landing w/ more speculative non-darwin build fixes.
Mark Lam
Comment 12 2019-09-03 18:47:40 PDT
EWS bots are happy. Landed in r249449: <http://trac.webkit.org/r249449>.
Note You need to log in before you can comment on or make changes to this bug.