Bug 201413

Summary: Remove the need to pass performJITMemcpy as a pointer.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, sbarati, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch.
msaboff: review+
patch for landing.
none
patch for landing.
none
patch for landing.
none
patch for landing.
none
patch for landing w/ more speculative non-darwin build fixes. none

Description Mark Lam 2019-09-02 19:15:23 PDT
We can always use a direct branch.
Comment 1 Mark Lam 2019-09-02 19:15:44 PDT
I meant, we can always use a direct call.
Comment 2 Mark Lam 2019-09-02 19:18:29 PDT
Created attachment 377868 [details]
proposed patch.
Comment 3 Radar WebKit Bug Importer 2019-09-02 19:18:53 PDT
<rdar://problem/54961451>
Comment 4 Mark Lam 2019-09-03 08:10:01 PDT
(In reply to Mark Lam from comment #1)
> I meant, we can always use a direct call.

Actually, we want performJITMemcpy to always be inlined.
Comment 5 Mark Lam 2019-09-03 08:14:10 PDT
Created attachment 377896 [details]
proposed patch.
Comment 6 Michael Saboff 2019-09-03 08:32:21 PDT
Comment on attachment 377896 [details]
proposed patch.

r=me
Comment 7 Mark Lam 2019-09-03 10:03:17 PDT
Created attachment 377902 [details]
patch for landing.

Thanks for the review.
Comment 8 Mark Lam 2019-09-03 12:20:32 PDT
Created attachment 377912 [details]
patch for landing.
Comment 9 Mark Lam 2019-09-03 13:08:03 PDT
Created attachment 377915 [details]
patch for landing.
Comment 10 Mark Lam 2019-09-03 13:40:20 PDT
Created attachment 377917 [details]
patch for landing.
Comment 11 Mark Lam 2019-09-03 15:03:20 PDT
Created attachment 377925 [details]
patch for landing w/ more speculative non-darwin build fixes.
Comment 12 Mark Lam 2019-09-03 18:47:40 PDT
EWS bots are happy.

Landed in r249449: <http://trac.webkit.org/r249449>.