Bug 201400

Summary: Move checkProcessLocalPortForActivity from provider to registry
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201299    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Rebasing
none
Patch
none
Patch for landing none

Description youenn fablet 2019-09-02 06:56:37 PDT 
This function is only used in the process managing the registry.
Comment 1 youenn fablet 2019-09-02 06:59:58 PDT 
Created attachment 377851 [details]
Patch
Comment 2 youenn fablet 2019-09-02 07:49:19 PDT 
Created attachment 377852 [details]
Patch
Comment 3 youenn fablet 2019-09-04 07:08:50 PDT 
Created attachment 377978 [details]
Rebasing
Comment 4 youenn fablet 2019-09-04 07:36:42 PDT 
Created attachment 377980 [details]
Patch
Comment 5 youenn fablet 2019-09-04 12:20:00 PDT 
Comment on attachment 377980 [details]
Patch

Will fix win
Comment 6 youenn fablet 2019-09-05 00:11:35 PDT 
Win error seems to be that it tries to use MessagePortChannelRegistry copy constructor in MessagePortChannelProviderImpl.cpp.
This constructor is not available and other compilers use the move constructor.
Brent, Per Arne, do you know what the issue might be on the win bot?
Comment 7 Per Arne Vollan 2019-09-05 08:24:04 PDT 
(In reply to youenn fablet from comment #6)
> Win error seems to be that it tries to use MessagePortChannelRegistry copy
> constructor in MessagePortChannelProviderImpl.cpp.
> This constructor is not available and other compilers use the move
> constructor.
> Brent, Per Arne, do you know what the issue might be on the win bot?

WinCairo seems to build successfully, maybe VS needs to be updated?
Comment 8 youenn fablet 2019-09-08 23:55:50 PDT 
> WinCairo seems to build successfully, maybe VS needs to be updated?

Maybe copy elision is different with WinCairo.
I'll workaround that for now.
Comment 9 youenn fablet 2019-09-09 00:09:08 PDT 
Created attachment 378349 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2019-09-09 01:50:57 PDT 
Comment on attachment 378349 [details]
Patch for landing

Clearing flags on attachment: 378349

Committed r249637: <https://trac.webkit.org/changeset/249637>
Comment 11 WebKit Commit Bot 2019-09-09 01:50:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-09-09 01:51:19 PDT 
<rdar://problem/55175067>
Comment 13 Radar WebKit Bug Importer 2019-09-09 01:51:21 PDT 
<rdar://problem/55175069>