Bug 201400

Summary: Move checkProcessLocalPortForActivity from provider to registry
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201299    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Rebasing
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-09-02 06:56:37 PDT
This function is only used in the process managing the registry.
Attachments
Patch (30.50 KB, patch)
2019-09-02 06:59 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (68.07 KB, patch)
2019-09-02 07:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (29.51 KB, patch)
2019-09-04 07:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.50 KB, patch)
2019-09-04 07:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.53 KB, patch)
2019-09-09 00:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-09-02 06:59:58 PDT
Created attachment 377851 [details] Patch
youenn fablet
Comment 2 2019-09-02 07:49:19 PDT
Created attachment 377852 [details] Patch
youenn fablet
Comment 3 2019-09-04 07:08:50 PDT
Created attachment 377978 [details] Rebasing
youenn fablet
Comment 4 2019-09-04 07:36:42 PDT
Created attachment 377980 [details] Patch
youenn fablet
Comment 5 2019-09-04 12:20:00 PDT
Comment on attachment 377980 [details] Patch Will fix win
youenn fablet
Comment 6 2019-09-05 00:11:35 PDT
Win error seems to be that it tries to use MessagePortChannelRegistry copy constructor in MessagePortChannelProviderImpl.cpp. This constructor is not available and other compilers use the move constructor. Brent, Per Arne, do you know what the issue might be on the win bot?
Per Arne Vollan
Comment 7 2019-09-05 08:24:04 PDT
(In reply to youenn fablet from comment #6) > Win error seems to be that it tries to use MessagePortChannelRegistry copy > constructor in MessagePortChannelProviderImpl.cpp. > This constructor is not available and other compilers use the move > constructor. > Brent, Per Arne, do you know what the issue might be on the win bot? WinCairo seems to build successfully, maybe VS needs to be updated?
youenn fablet
Comment 8 2019-09-08 23:55:50 PDT
> WinCairo seems to build successfully, maybe VS needs to be updated? Maybe copy elision is different with WinCairo. I'll workaround that for now.
youenn fablet
Comment 9 2019-09-09 00:09:08 PDT
Created attachment 378349 [details] Patch for landing
WebKit Commit Bot
Comment 10 2019-09-09 01:50:57 PDT
Comment on attachment 378349 [details] Patch for landing Clearing flags on attachment: 378349 Committed r249637: <https://trac.webkit.org/changeset/249637>
WebKit Commit Bot
Comment 11 2019-09-09 01:50:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-09-09 01:51:19 PDT
<rdar://problem/55175067>
Radar WebKit Bug Importer
Comment 13 2019-09-09 01:51:21 PDT
<rdar://problem/55175069>
Note You need to log in before you can comment on or make changes to this bug.