| Summary: | Add support to RTCDataChannel.send(Blob) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 201359 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2019-08-31 04:06:27 PDT
Created attachment 377797 [details]
Patch
Created attachment 378052 [details]
Patch
ping review Comment on attachment 378052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378052&action=review > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87 > + , m_messageQueue(createMessageQueue(downcast<Document>(context), *this)) Can the constructor be updated to take a Document& instead of having an unsafe-looking downcast here? (In reply to Chris Dumez from comment #4) > Comment on attachment 378052 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378052&action=review > > > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87 > > + , m_messageQueue(createMessageQueue(downcast<Document>(context), *this)) > > Can the constructor be updated to take a Document& instead of having an > unsafe-looking downcast here? Right, let's do that as another patch since we should change RTCPeerConnection at the same time. > > Can the constructor be updated to take a Document& instead of having an > > unsafe-looking downcast here? > > Right, let's do that as another patch since we should change > RTCPeerConnection at the same time. Filed bug 201639. Comment on attachment 378052 [details] Patch Clearing flags on attachment: 378052 Committed r249710: <https://trac.webkit.org/changeset/249710> All reviewed patches have been landed. Closing bug. |