Bug 201377

Summary: Add support to RTCDataChannel.send(Blob)
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201359    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2019-08-31 04:06:27 PDT
Add support to RTCDataChannel.send(Blob)
Attachments
Patch (11.37 KB, patch)
2019-08-31 04:14 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.10 KB, patch)
2019-09-05 00:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-08-31 04:14:17 PDT
Created attachment 377797 [details] Patch
youenn fablet
Comment 2 2019-09-05 00:03:38 PDT
Created attachment 378052 [details] Patch
youenn fablet
Comment 3 2019-09-09 02:26:57 PDT
ping review
Chris Dumez
Comment 4 2019-09-09 08:49:28 PDT
Comment on attachment 378052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378052&action=review > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87 > + , m_messageQueue(createMessageQueue(downcast<Document>(context), *this)) Can the constructor be updated to take a Document& instead of having an unsafe-looking downcast here?
youenn fablet
Comment 5 2019-09-10 04:20:15 PDT
(In reply to Chris Dumez from comment #4) > Comment on attachment 378052 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378052&action=review > > > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87 > > + , m_messageQueue(createMessageQueue(downcast<Document>(context), *this)) > > Can the constructor be updated to take a Document& instead of having an > unsafe-looking downcast here? Right, let's do that as another patch since we should change RTCPeerConnection at the same time.
youenn fablet
Comment 6 2019-09-10 04:21:59 PDT
> > Can the constructor be updated to take a Document& instead of having an > > unsafe-looking downcast here? > > Right, let's do that as another patch since we should change > RTCPeerConnection at the same time. Filed bug 201639.
WebKit Commit Bot
Comment 7 2019-09-10 05:04:51 PDT
Comment on attachment 378052 [details] Patch Clearing flags on attachment: 378052 Committed r249710: <https://trac.webkit.org/changeset/249710>
WebKit Commit Bot
Comment 8 2019-09-10 05:04:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-10 05:05:19 PDT
<rdar://problem/55219034>
Note You need to log in before you can comment on or make changes to this bug.