Bug 201364

Summary: DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2019-08-30 16:12:30 PDT
DocumentStorageAccess::hasStorageAccess() / requestStorageAccess() don't need to know about pageID / frameID. pageID is redundant since it is being ignored by the callee. For the frame, simply pass the frame object in.
Comment 1 Chris Dumez 2019-08-30 16:21:52 PDT
Created attachment 377764 [details]
Patch
Comment 2 John Wilander 2019-08-30 16:47:02 PDT
Comment on attachment 377764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377764&action=review

LGTM. See nit.

> Source/WebCore/page/ChromeClient.h:-491
> -    virtual void requestStorageAccess(RegistrableDomain&& /*subFrameDomain*/, RegistrableDomain&& /*topFrameDomain*/, FrameIdentifier, PageIdentifier, WTF::CompletionHandler<void(StorageAccessWasGranted, StorageAccessPromptWasShown)>&& completionHandler) { completionHandler(StorageAccessWasGranted::No, StorageAccessPromptWasShown::No); }

Now you can remove #include "FrameIdentifier.h"
Comment 3 Chris Dumez 2019-08-30 16:48:45 PDT
Created attachment 377771 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-31 00:52:26 PDT
Comment on attachment 377771 [details]
Patch

Clearing flags on attachment: 377771

Committed r249359: <https://trac.webkit.org/changeset/249359>
Comment 5 WebKit Commit Bot 2019-08-31 00:52:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-31 00:53:17 PDT
<rdar://problem/54911112>