Bug 201317

Summary: Caret does not appear in text field inside a transformed, overflow: hidden container
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, info, megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Simple test case
none
Patch
simon.fraser: review+
Patch for landing none

Description Wenson Hsieh 2019-08-29 16:04:18 PDT 
Followup to <https://bugs.webkit.org/show_bug.cgi?id=201287>.
Comment 1 Radar WebKit Bug Importer 2019-08-29 16:06:55 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-08-29 16:16:29 PDT 
Created attachment 377650 [details]
Simple test case
Comment 3 Wenson Hsieh 2019-08-29 16:56:58 PDT 
<rdar://problem/54849701>
Comment 4 Wenson Hsieh 2019-08-29 16:58:09 PDT 
(In reply to Wenson Hsieh from comment #3)
> <rdar://problem/54849701>

I’m using this Radar instead of the imported one, since this is the report Pierre filed. It’s also earlier than the imported one.
Comment 5 Wenson Hsieh 2019-08-29 21:22:37 PDT 
Created attachment 377674 [details]
Patch
Comment 6 Wenson Hsieh 2019-08-30 11:27:33 PDT 
Comment on attachment 377674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377674&action=review

Thanks for the review!

> Source/WebCore/ChangeLog:18
> +        field is now visible. Somce RenderLayer::offsetFromAncestor doesn't take transforms into account when we try to

Oops, “Somce" => “Since”

Going to fix this typo before I land.
Comment 7 Wenson Hsieh 2019-08-30 11:46:46 PDT 
Created attachment 377736 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-08-30 12:29:03 PDT 
Comment on attachment 377736 [details]
Patch for landing

Clearing flags on attachment: 377736

Committed r249339: <https://trac.webkit.org/changeset/249339>