Bug 201317 - Caret does not appear in text field inside a transformed, overflow: hidden container
Summary: Caret does not appear in text field inside a transformed, overflow: hidden co...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2019-08-29 16:04 PDT by Wenson Hsieh
Modified: 2019-09-03 08:02 PDT (History)
8 users (show)

See Also:

Simple test case (973 bytes, text/html)
2019-08-29 16:16 PDT, Wenson Hsieh
no flags Details
Patch (14.03 KB, patch)
2019-08-29 21:22 PDT, Wenson Hsieh
simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (13.98 KB, patch)
2019-08-30 11:46 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-08-29 16:04:18 PDT
Followup to <https://bugs.webkit.org/show_bug.cgi?id=201287>.
Comment 1 Radar WebKit Bug Importer 2019-08-29 16:06:55 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-08-29 16:16:29 PDT
Created attachment 377650 [details]
Simple test case
Comment 3 Wenson Hsieh 2019-08-29 16:56:58 PDT
Comment 4 Wenson Hsieh 2019-08-29 16:58:09 PDT
(In reply to Wenson Hsieh from comment #3)
> <rdar://problem/54849701>

I’m using this Radar instead of the imported one, since this is the report Pierre filed. It’s also earlier than the imported one.
Comment 5 Wenson Hsieh 2019-08-29 21:22:37 PDT
Created attachment 377674 [details]
Comment 6 Wenson Hsieh 2019-08-30 11:27:33 PDT
Comment on attachment 377674 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=377674&action=review

Thanks for the review!

> Source/WebCore/ChangeLog:18
> +        field is now visible. Somce RenderLayer::offsetFromAncestor doesn't take transforms into account when we try to

Oops, “Somce" => “Since”

Going to fix this typo before I land.
Comment 7 Wenson Hsieh 2019-08-30 11:46:46 PDT
Created attachment 377736 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-08-30 12:29:03 PDT
Comment on attachment 377736 [details]
Patch for landing

Clearing flags on attachment: 377736

Committed r249339: <https://trac.webkit.org/changeset/249339>