Summary: | Speculative loads should use the NetworkSession owning their Cache | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 214008 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alex Christensen
2019-08-29 15:25:47 PDT
Created attachment 377634 [details]
Patch
Created attachment 377635 [details]
Patch
Comment on attachment 377635 [details] Patch Clearing flags on attachment: 377635 Committed r249303: <https://trac.webkit.org/changeset/249303> All reviewed patches have been landed. Closing bug. Comment on attachment 377635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377635&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:62 > + m_networkLoad = makeUnique<NetworkLoad>(*this, nullptr, WTFMove(parameters), *cache.networkProcess().networkSession(cache.sessionID())); Turns out this may return a null session now and do a null Derek of the session in the NetworkLoad constructor. See Bug 214008. |