Bug 201314

Summary:

Speculative loads should use the NetworkSession owning their Cache

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

214008

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2019-08-29 15:25:47 PDT

Speculative loads should use the NetworkSession owning their Cache

Comment 1 Alex Christensen 2019-08-29 15:26:58 PDT

Created attachment 377634 [details]
Patch

Comment 2 Alex Christensen 2019-08-29 15:31:49 PDT

Created attachment 377635 [details]
Patch

Comment 3 WebKit Commit Bot 2019-08-29 17:17:48 PDT

Comment on attachment 377635 [details]
Patch

Clearing flags on attachment: 377635

Committed r249303: <https://trac.webkit.org/changeset/249303>

Comment 4 WebKit Commit Bot 2019-08-29 17:17:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-08-29 17:18:20 PDT

<rdar://problem/54862251>

Comment 6 Chris Dumez 2020-07-06 14:43:29 PDT

Comment on attachment 377635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377635&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:62
> +    m_networkLoad = makeUnique<NetworkLoad>(*this, nullptr, WTFMove(parameters), *cache.networkProcess().networkSession(cache.sessionID()));

Turns out this may return a null session now and do a null Derek of the session in the NetworkLoad constructor. See Bug 214008.