Bug 201312

Summary: Disable CFNetwork AppSSO interception for WebKitLegacy
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: NEW    
Severity: Normal CC: bfulgham, jiewen_tan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review-

Jiewen Tan
Reported 2019-08-29 14:10:36 PDT
Disable CFNetwork AppSSO interception for WebKitLegacy.
Attachments
Patch (1.40 KB, patch)
2019-08-29 14:16 PDT, Jiewen Tan
sam: review-
Radar WebKit Bug Importer
Comment 1 2019-08-29 14:10:55 PDT
Jiewen Tan
Comment 2 2019-08-29 14:16:04 PDT
Sam Weinig
Comment 3 2019-08-29 17:24:00 PDT
Comment on attachment 377624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377624&action=review > Source/WebKitLegacy/mac/ChangeLog:5 > + Disable CFNetwork AppSSO interception for WebKitLegacy > + https://bugs.webkit.org/show_bug.cgi?id=201312 > + <rdar://problem/54853399> Please include an explanation of why this change is being made in the ChangeLog. > Source/WebKitLegacy/mac/WebView/WebView.mm:1592 > +#if HAVE(APP_SSO) > + [NSURLSession _disableAppSSO]; > +#endif What is the effect outside of WebKit of doing this? From the name, it doesn't seem like this would only effect url sessions that WebKit creates, which seems like it could be a problem.
Jiewen Tan
Comment 4 2019-08-30 16:58:13 PDT
Comment on attachment 377624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377624&action=review Thanks Sam for reviewing the patch. >> Source/WebKitLegacy/mac/ChangeLog:5 >> + <rdar://problem/54853399> > > Please include an explanation of why this change is being made in the ChangeLog. Sure. >> Source/WebKitLegacy/mac/WebView/WebView.mm:1592 >> +#endif > > What is the effect outside of WebKit of doing this? From the name, it doesn't seem like this would only effect url sessions that WebKit creates, which seems like it could be a problem. Right. I will double check with CFNetwork if they could provide a per connection version.
Note You need to log in before you can comment on or make changes to this bug.