Bug 201307 – [MSE][GStreamer] Replaying the video should update currentTime

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Alicia Boya García]

While writing a test to confirm that https://bugs.webkit.org/show_bug.cgi?id=190050
has indeed been fixed I noticed a non-conformity: when the video has
ended, right after calling .play() for a second playback currentTime
did not return zero, but the video duration.

This turned to be due to the m_isEndReached flag not being reseted on
seeks (replaying a video incurs in a seek done from multi-platform
code).

[Alicia Boya García]

Created attachment 377611 [details]
Patch

[Alicia Boya García]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/18756

[Philippe Normand]

Comment on attachment 377611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377611&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:147
> +    GST_DEBUG("MediaPlayerPrivateGStreamerMSE::seek(%p): %s", this, time.toString().utf8().data());

Nitpicks:

GST_DEBUG_OBJECT(pipeline(), "Seeking to %s", time.toString().utf8().data());

[Alicia Boya García]

Created attachment 377720 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377720 [details]
Patch

Clearing flags on attachment: 377720

Committed r249332: <https://trac.webkit.org/changeset/249332>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.