Bug 201307 - [MSE][GStreamer] Replaying the video should update currentTime
Summary: [MSE][GStreamer] Replaying the video should update currentTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-29 12:31 PDT by Alicia Boya García
Modified: 2019-08-30 10:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2019-08-29 12:34 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2019-08-30 09:47 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-08-29 12:31:47 PDT
While writing a test to confirm that https://bugs.webkit.org/show_bug.cgi?id=190050
has indeed been fixed I noticed a non-conformity: when the video has
ended, right after calling .play() for a second playback currentTime
did not return zero, but the video duration.

This turned to be due to the m_isEndReached flag not being reseted on
seeks (replaying a video incurs in a seek done from multi-platform
code).
Comment 1 Alicia Boya García 2019-08-29 12:34:03 PDT
Created attachment 377611 [details]
Patch
Comment 2 Alicia Boya García 2019-08-29 12:34:54 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/18756
Comment 3 Philippe Normand 2019-08-30 01:58:50 PDT
Comment on attachment 377611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377611&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:147
> +    GST_DEBUG("MediaPlayerPrivateGStreamerMSE::seek(%p): %s", this, time.toString().utf8().data());

Nitpicks:

GST_DEBUG_OBJECT(pipeline(), "Seeking to %s", time.toString().utf8().data());
Comment 4 Alicia Boya García 2019-08-30 09:47:11 PDT
Created attachment 377720 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-30 10:17:27 PDT
Comment on attachment 377720 [details]
Patch

Clearing flags on attachment: 377720

Committed r249332: <https://trac.webkit.org/changeset/249332>
Comment 6 WebKit Commit Bot 2019-08-30 10:17:28 PDT
All reviewed patches have been landed.  Closing bug.