Bug 201280

Summary: Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200694
Attachments:
Description Flags
Patch youennf: review+

Keith Rollin
Reported 2019-08-28 20:31:13 PDT
HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT is always True, so remove the conditional tests, keeping the True branches and removing the False branches.
Attachments
Patch (4.42 KB, patch)
2019-08-29 07:35 PDT, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-28 20:31:23 PDT
<rdar://problem/54821367>
Alex Christensen
Comment 2 2019-08-29 07:35:49 PDT
Created attachment 377583 [details] Patch
Darin Adler
Comment 3 2019-08-29 08:59:18 PDT
Comment on attachment 377583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review > Source/WTF/wtf/Platform.h:-1444 > -/* FIXME: Does this work, and is this needed on other iOS family platforms? */ Do you know the answer to this?
Alex Christensen
Comment 4 2019-08-29 22:23:30 PDT
Comment on attachment 377583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review >> Source/WTF/wtf/Platform.h:-1444 >> -/* FIXME: Does this work, and is this needed on other iOS family platforms? */ > > Do you know the answer to this? "git show cf848588" in CFNetwork indicates there's nothing platform specific about this. Alexey added this question in r238785 and I believe it was because he removed a respondsToSelector check which is indeed not needed on any platform.
Alex Christensen
Comment 5 2019-08-30 13:27:51 PDT
https://trac.webkit.org/changeset/249343/webkit
Note You need to log in before you can comment on or make changes to this bug.