Bug 201233

Summary: Dissociate the WebPageProxy's identifier from the WebPage's
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, mcrha, rniwa, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201504
Bug Depends on:    
Bug Blocks: 201225    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch none

Chris Dumez
Reported 2019-08-28 13:58:09 PDT
Dissociate the WebPageProxy's identifier from the WebPage's to help support Bug 201225.
Attachments
WIP Patch (283.58 KB, patch)
2019-08-28 13:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (318.68 KB, patch)
2019-08-28 14:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (319.50 KB, patch)
2019-08-28 14:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (319.50 KB, patch)
2019-08-28 15:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (357.33 KB, patch)
2019-08-28 15:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-28 13:59:46 PDT
Created attachment 377477 [details] WIP Patch
Chris Dumez
Comment 2 2019-08-28 14:17:51 PDT
Created attachment 377485 [details] WIP Patch
Chris Dumez
Comment 3 2019-08-28 14:29:48 PDT
Created attachment 377489 [details] WIP Patch
Chris Dumez
Comment 4 2019-08-28 15:25:36 PDT
Created attachment 377495 [details] WIP Patch
Chris Dumez
Comment 5 2019-08-28 15:53:58 PDT
Created attachment 377500 [details] Patch
Chris Dumez
Comment 6 2019-08-29 08:28:28 PDT
Comment on attachment 377500 [details] Patch Clearing flags on attachment: 377500 Committed r249275: <https://trac.webkit.org/changeset/249275>
Chris Dumez
Comment 7 2019-08-29 08:28:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-08-29 08:29:17 PDT
<rdar://problem/54837423>
Milan Crha
Comment 9 2019-09-02 22:58:44 PDT
For the record, one part of bug #201033 contains a regression this change could cause, that webkit_web_page_get_id() doesn't match webkit_web_view_get_page_id() any more. The bug #201033 contains tests which prove it. More info there.
Note You need to log in before you can comment on or make changes to this bug.