Bug 201224

Summary:

Remove support for macOS < 10.13 (part 3)

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

WebKit Misc.

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, eric.carlson, ews-watchlist, keith_miller, mark.lam, mmaxfield, msaboff, saam, thorton, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201197
https://bugs.webkit.org/show_bug.cgi?id=200694

Attachments:

Description	Flags
Patch	none
Patch	none

Keith Rollin

Reported 2019-08-28 10:14:46 PDT

Remove symbols in WebKitTargetConditionals.xcconfig related to macOS 10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes like _MACOS_SINCE_1013.

Attachments
Patch (22.72 KB, patch) 2019-08-28 10:26 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Patch (22.72 KB, patch) 2019-08-28 16:13 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-08-28 10:15:11 PDT

<rdar://problem/54795934>

Keith Rollin

Comment 2 2019-08-28 10:26:35 PDT

Created attachment 377458 [details] Patch

Keith Rollin

Comment 3 2019-08-28 16:12:53 PDT

Those build failures were because this patch relied on a previous patch having first landed. I had jumped the gun and that previous patch was still in the commit queue and not yet landed. I'm uploading this patch again now that the previous patch has actually landed.

Keith Rollin

Comment 4 2019-08-28 16:13:48 PDT

Created attachment 377504 [details] Patch

WebKit Commit Bot

Comment 5 2019-08-29 12:22:29 PDT

Comment on attachment 377504 [details] Patch Clearing flags on attachment: 377504 Committed r249286: <https://trac.webkit.org/changeset/249286>

WebKit Commit Bot

Comment 6 2019-08-29 12:22:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.