Bug 201219

Summary: Implement HTMLOrForeignElement
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, kondapallykalyan, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200470    
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2019-08-28 08:12:06 PDT
See https://bugs.webkit.org/show_bug.cgi?id=200470.
Attachments
Patch (16.18 KB, patch)
2019-08-28 09:04 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2019-08-29 00:12 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-08-28 09:04:35 PDT
Created attachment 377449 [details] Patch
WebKit Commit Bot
Comment 2 2019-08-28 12:34:50 PDT
Comment on attachment 377449 [details] Patch Clearing flags on attachment: 377449 Committed r249212: <https://trac.webkit.org/changeset/249212>
WebKit Commit Bot
Comment 3 2019-08-28 12:34:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-08-28 12:35:18 PDT
<rdar://problem/54803120>
Sam Weinig
Comment 5 2019-08-28 14:42:58 PDT
The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a different name?
Ryosuke Niwa
Comment 6 2019-08-28 17:14:18 PDT
(In reply to Sam Weinig from comment #5) > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > different name? It’s getting renamed to incorporate MathML as a part of MathML revamp. See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs.
Sam Weinig
Comment 7 2019-08-28 17:44:42 PDT
(In reply to Ryosuke Niwa from comment #6) > (In reply to Sam Weinig from comment #5) > > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > > different name? > > It’s getting renamed to incorporate MathML as a part of MathML revamp. > > See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs. Ok. It's pretty confusing to have a link to https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a comment, which has a different name, without some explanation that the name is going to be changed in the spec at some point.
Ryosuke Niwa
Comment 8 2019-08-28 19:38:09 PDT
Comment on attachment 377449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377449&action=review > Source/WebCore/html/HTMLOrForeignElement.idl:26 > +// https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement Yeah, we should probably add a FIXME here referring to https://github.com/mathml-refresh/mathml/issues/83.
Ryosuke Niwa
Comment 9 2019-08-28 19:38:36 PDT
(In reply to Sam Weinig from comment #7) > (In reply to Ryosuke Niwa from comment #6) > > (In reply to Sam Weinig from comment #5) > > > The WHATWG spec calls this mixing HTMLOrSVGElement. Why did we go with a > > > different name? > > > > It’s getting renamed to incorporate MathML as a part of MathML revamp. > > > > See https://bugs.webkit.org/show_bug.cgi?id=195797 and related bugs. > > Ok. It's pretty confusing to have a link to > https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a > comment, which has a different name, without some explanation that the name > is going to be changed in the spec at some point. Oh, oops, I missed that. Indeed, that's confusing. We should probably add a FIXME there.
Rob Buis
Comment 10 2019-08-29 00:11:59 PDT
Reopening to attach new patch.
Rob Buis
Comment 11 2019-08-29 00:12:01 PDT
Created attachment 377550 [details] Patch
Rob Buis
Comment 12 2019-08-29 00:18:08 PDT
(In reply to Ryosuke Niwa from comment #9) > (In reply to Sam Weinig from comment #7) > > Ok. It's pretty confusing to have a link to > > https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement in a > > comment, which has a different name, without some explanation that the name > > is going to be changed in the spec at some point. > > Oh, oops, I missed that. Indeed, that's confusing. We should probably add a > FIXME there. Agreed, it is confusing, will fix.
WebKit Commit Bot
Comment 13 2019-08-29 01:30:12 PDT
Comment on attachment 377550 [details] Patch Clearing flags on attachment: 377550 Committed r249249: <https://trac.webkit.org/changeset/249249>
WebKit Commit Bot
Comment 14 2019-08-29 01:30:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.