Bug 201204

Summary: [ews] Status bubble should be white for CANCELLED builds
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-01 for mac-highsierra
none
Patch none

Description Aakash Jain 2019-08-27 15:12:47 PDT
Status bubble should be red for CANCELLED builds. Currently they are orange which might make people think that EWS is retrying, and they should wait. Instead the bubble should be red. Builds can be CANCELLED by the admin.
Comment 1 Aakash Jain 2019-08-27 15:15:54 PDT
Created attachment 377391 [details]
Patch
Comment 2 Aakash Jain 2019-08-27 15:20:52 PDT
I cancelled a build in https://ews-build.webkit.org/#/builders/6/builds/2006 (as the patch was obsolete and bot was taking extremely long to apply the patch). That prompted me to notice this issue.
Comment 3 WebKit Commit Bot 2019-08-27 16:53:56 PDT
Comment on attachment 377391 [details]
Patch

Rejecting attachment 377391 [details] from commit-queue.

New failing tests:
fullscreen/full-screen-request-removed-with-raf.html
Full output: https://webkit-queues.webkit.org/results/12974872
Comment 4 WebKit Commit Bot 2019-08-27 16:53:58 PDT
Created attachment 377401 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 Ryan Haddad 2019-08-27 16:56:14 PDT
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 377391 [details]
> Patch
> 
> Rejecting attachment 377391 [details] from commit-queue.
> 
> New failing tests:
> fullscreen/full-screen-request-removed-with-raf.html
> Full output: https://webkit-queues.webkit.org/results/12974872
This failure is tracked with https://bugs.webkit.org/show_bug.cgi?id=201188
Comment 6 WebKit Commit Bot 2019-08-27 19:39:09 PDT
Comment on attachment 377391 [details]
Patch

Clearing flags on attachment: 377391

Committed r249189: <https://trac.webkit.org/changeset/249189>
Comment 7 WebKit Commit Bot 2019-08-27 19:39:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-27 19:40:22 PDT
<rdar://problem/54774731>
Comment 9 Alexey Proskuryakov 2019-08-27 19:46:29 PDT
IIRC it was white with old EWS. Red seems reasonable too.
Comment 10 Aakash Jain 2019-11-04 13:32:45 PST
(In reply to Alexey Proskuryakov from comment #9)
> IIRC it was white with old EWS. Red seems reasonable too.
I agree, white seems more sense. 

Red bubble would indicate some issue with the patch, and might prompt users to debug the Cancelled build. White bubble would indicate that the patch wasn't tested, which is the case of CANCELLED builds.

I cancelled few ongoing builds (and clicked rebuild, so that they build again with ToT) after wincairo build fix (e.g.: https://ews-build.webkit.org/#/builders/12/builds/9658), which caused me to notice this issue.
Comment 11 Aakash Jain 2019-11-04 13:34:53 PST
Created attachment 382767 [details]
Patch
Comment 12 WebKit Commit Bot 2019-11-04 15:06:09 PST
Comment on attachment 382767 [details]
Patch

Clearing flags on attachment: 382767

Committed r252017: <https://trac.webkit.org/changeset/252017>
Comment 13 WebKit Commit Bot 2019-11-04 15:06:10 PST
All reviewed patches have been landed.  Closing bug.