Summary: | [ews] Status bubble should be white for CANCELLED builds | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, ryanhaddad, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Aakash Jain
2019-08-27 15:12:47 PDT
Created attachment 377391 [details]
Patch
I cancelled a build in https://ews-build.webkit.org/#/builders/6/builds/2006 (as the patch was obsolete and bot was taking extremely long to apply the patch). That prompted me to notice this issue. Comment on attachment 377391 [details] Patch Rejecting attachment 377391 [details] from commit-queue. New failing tests: fullscreen/full-screen-request-removed-with-raf.html Full output: https://webkit-queues.webkit.org/results/12974872 Created attachment 377401 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 377391 [details] > Patch > > Rejecting attachment 377391 [details] from commit-queue. > > New failing tests: > fullscreen/full-screen-request-removed-with-raf.html > Full output: https://webkit-queues.webkit.org/results/12974872 This failure is tracked with https://bugs.webkit.org/show_bug.cgi?id=201188 Comment on attachment 377391 [details] Patch Clearing flags on attachment: 377391 Committed r249189: <https://trac.webkit.org/changeset/249189> All reviewed patches have been landed. Closing bug. IIRC it was white with old EWS. Red seems reasonable too. (In reply to Alexey Proskuryakov from comment #9) > IIRC it was white with old EWS. Red seems reasonable too. I agree, white seems more sense. Red bubble would indicate some issue with the patch, and might prompt users to debug the Cancelled build. White bubble would indicate that the patch wasn't tested, which is the case of CANCELLED builds. I cancelled few ongoing builds (and clicked rebuild, so that they build again with ToT) after wincairo build fix (e.g.: https://ews-build.webkit.org/#/builders/12/builds/9658), which caused me to notice this issue. Created attachment 382767 [details]
Patch
Comment on attachment 382767 [details] Patch Clearing flags on attachment: 382767 Committed r252017: <https://trac.webkit.org/changeset/252017> All reviewed patches have been landed. Closing bug. |