Bug 201202

Summary: Update PACCage changes for builds without Gigacage, but with signed pointers
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Michael Saboff
Reported 2019-08-27 14:10:53 PDT
The PACCage changes which landed in r247101 don't properly handle the case where Giga Cage is not enabled, either at compile time or runtime, and we have data pointer signing. A little restructuring is needed to make it right.
Attachments
Patch (7.10 KB, patch)
2019-08-27 14:27 PDT, Michael Saboff 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2019-08-27 14:11:23 PDT
<rdar://problem/54571261>
Michael Saboff
Comment 2 2019-08-27 14:27:06 PDT
Created attachment 377383 [details] Patch
Saam Barati
Comment 3 2019-08-27 15:06:30 PDT
Comment on attachment 377383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377383&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + Update PACCage changes for builds without Giga Cage, but with signed pointers "Giga Cage" => "Gigacage" > Source/JavaScriptCore/ChangeLog:8 > + Factored out the untaging of pointers and added that to both the Giga Cage enabled "Giga Cage" => "Gigacage" "untaging" -> "untagging"
Michael Saboff
Comment 4 2019-08-27 16:47:51 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 377383 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377383&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:3 > > + Update PACCage changes for builds without Giga Cage, but with signed pointers > > "Giga Cage" => "Gigacage" > > > Source/JavaScriptCore/ChangeLog:8 > > + Factored out the untaging of pointers and added that to both the Giga Cage enabled > > "Giga Cage" => "Gigacage" > "untaging" -> "untagging" I made these changes locally.
Michael Saboff
Comment 5 2019-08-27 16:48:56 PDT
Committed r249184: <https://trac.webkit.org/changeset/249184>
Note You need to log in before you can comment on or make changes to this bug.