Bug 201200

Summary: GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, mitz, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Dean Jackson
Reported 2019-08-27 13:45:13 PDT
GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
Attachments
Patch (1.44 KB, patch)
2019-08-27 13:47 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2019-08-27 16:07 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2019-08-27 13:47:34 PDT
Created attachment 377377 [details] Patch
Dean Jackson
Comment 2 2019-08-27 16:07:39 PDT
Created attachment 377396 [details] Patch
Dean Jackson
Comment 3 2019-08-28 12:51:14 PDT
Committed r249211: <https://trac.webkit.org/changeset/249211>
Radar WebKit Bug Importer
Comment 4 2019-08-28 12:52:19 PDT
<rdar://problem/54803748>
mitz
Comment 5 2019-08-28 12:59:38 PDT
Comment on attachment 377396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377396&action=review > Source/WebKitLegacy/mac/Misc/WebDownload.h:38 > #import <Foundation/NSURLDownload.h> I don’t see this public header in the latest iOS 13.0 beta SDK. So this doesn’t seem to be a good fix.
Dean Jackson
Comment 6 2019-08-28 18:50:47 PDT
(In reply to mitz from comment #5) > Comment on attachment 377396 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377396&action=review > > > Source/WebKitLegacy/mac/Misc/WebDownload.h:38 > > #import <Foundation/NSURLDownload.h> > > I don’t see this public header in the latest iOS 13.0 beta SDK. So this > doesn’t seem to be a good fix. Correct. It's a private header. Thanks Dan.
Dean Jackson
Comment 7 2019-08-29 10:21:42 PDT
Reverted in r249281
Note You need to log in before you can comment on or make changes to this bug.