Bug 201193

Summary: Web Inspector: don't attach properties to `injectedScript` for the CommandLineAPI
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 200971    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-08-27 12:33:56 PDT
For some reason, specifying `injectedScript._inspectObject` inside CommandLineAPIModuleSource.js causes inspector/debugger/tail-deleted-frames-this-value.html to fail. We should have a similar approach to adding command line api getters/functions, in that the CommandLineAPIModuleSource.js calls a function with a callback.
Attachments
Patch (5.19 KB, patch)
2019-08-27 12:36 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (8.00 KB, patch)
2019-08-27 14:07 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-08-27 12:36:24 PDT
Created attachment 377367 [details] Patch
Joseph Pecoraro
Comment 2 2019-08-27 12:37:44 PDT
Comment on attachment 377367 [details] Patch r=me
Devin Rousso
Comment 3 2019-08-27 14:07:19 PDT
Created attachment 377380 [details] Patch
WebKit Commit Bot
Comment 4 2019-08-27 14:40:17 PDT
Comment on attachment 377380 [details] Patch Clearing flags on attachment: 377380 Committed r249173: <https://trac.webkit.org/changeset/249173>
WebKit Commit Bot
Comment 5 2019-08-27 14:40:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-27 14:41:17 PDT
<rdar://problem/54764148>
Note You need to log in before you can comment on or make changes to this bug.