Bug 201146

Summary:

Drop WEBCORE_EXPORT from ChromeClient class

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2019-08-26 13:13:19 PDT

Drop WEBCORE_EXPORT from ChromeClient class. All its methods and either pure virtual or inlined in the header.

Attachments
Patch (1.17 KB, patch) 2019-08-26 13:14 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-08-26 13:14:19 PDT

Created attachment 377264 [details] Patch

Alex Christensen

Comment 2 2019-08-26 14:32:20 PDT

Comment on attachment 377264 [details] Patch r=me, but what does this help?

Chris Dumez

Comment 3 2019-08-26 14:33:01 PDT

(In reply to Alex Christensen from comment #2) > Comment on attachment 377264 [details] > Patch > > r=me, but what does this help? It helps my sanity. Right now, the style checker keeps complaining about this every time I add a new method to this class :)

Chris Dumez

Comment 4 2019-08-26 14:34:21 PDT

(In reply to Chris Dumez from comment #3) > (In reply to Alex Christensen from comment #2) > > Comment on attachment 377264 [details] > > Patch > > > > r=me, but what does this help? > > It helps my sanity. Right now, the style checker keeps complaining about > this every time I add a new method to this class :) ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]

WebKit Commit Bot

Comment 5 2019-08-26 15:16:31 PDT

Comment on attachment 377264 [details] Patch Clearing flags on attachment: 377264 Committed r249119: <https://trac.webkit.org/changeset/249119>

WebKit Commit Bot

Comment 6 2019-08-26 15:16:33 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-08-26 15:17:23 PDT

<rdar://problem/54724331>

Note You need to log in before you can comment on or make changes to this bug.