Bug 201118
| Summary: | REGRESSION (r241660): CachedTypes.cpp is often recompiled during incremental builds because the Derived Sources build phase always touches BytecodeCacheVersion.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | krollin |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 194768 | ||
| Bug Blocks: | |||
Andy Estes
--- trunk/Source/JavaScriptCore/DerivedSources.make 2019-02-18 09:12:48 UTC (rev 241659)
+++ trunk/Source/JavaScriptCore/DerivedSources.make 2019-02-18 10:20:28 UTC (rev 241660)
@@ -356,3 +356,10 @@
all : \
$(OBJECT_LUT_HEADERS) \
#
+
+.PHONY : BytecodeCacheVersion.h
+
+BytecodeCacheVersion.h:
+ echo "#define JSC_BYTECODE_CACHE_VERSION $(shell date '+%s')" > BytecodeCacheVersion.h
+
+all : BytecodeCacheVersion.h
BytecodeCacheVersion.h has no dependencies, so it's always updated with the current date when the Derived Sources build phase runs. CachedTypes.cpp includes BytecodeCacheVersion.h.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |