Bug 201109

Summary: Add a script to update ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, ews-watchlist, graouts, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Patch none

Description James Darpinian 2019-08-23 17:34:05 PDT 
Add a script to update ANGLE
Comment 1 James Darpinian 2019-08-23 17:35:57 PDT 
Created attachment 377186 [details]
Patch
Comment 2 James Darpinian 2019-08-23 17:37:19 PDT 
*** Bug 201013 has been marked as a duplicate of this bug. ***
Comment 3 EWS Watchlist 2019-08-23 17:38:13 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 James Darpinian 2019-08-23 17:40:04 PDT 
This is no longer moving ANGLE to a different directory, it's just a single script file now.
Comment 5 Alex Christensen 2019-08-26 10:03:34 PDT 
Comment on attachment 377186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377186&action=review

> Source/ThirdParty/ANGLE/update-angle.sh:51
> +if ! git am changes.diff; then

This won't work for anyone using svn, but that's probably no big deal.
Comment 6 WebKit Commit Bot 2019-08-26 10:36:35 PDT 
Comment on attachment 377186 [details]
Patch

Clearing flags on attachment: 377186

Committed r249103: <https://trac.webkit.org/changeset/249103>
Comment 7 WebKit Commit Bot 2019-08-26 10:36:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-26 10:38:39 PDT 
<rdar://problem/54712643>
Comment 9 James Darpinian 2019-08-26 10:41:41 PDT 
Thanks! I believe the script should work for svn users as long as they have git installed. The script runs git in a clone of the ANGLE git repo, not the main WebKit repo.