Bug 201095

Summary: Web Inspector: "Copy Rule" menu item does not propagate comments properly
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Joseph Pecoraro 2019-08-23 15:25:53 PDT
"Copy Rule" menu item does not propagate comments properly

Steps to Reproduce:
1. Inspect <body> on about:blank
2. Add some properties
3. Disable some properties
4. Click Rule Icon > Copy Rule
5. Paste
  => Disabled "commented out" properties are not commented out
Comment 1 Devin Rousso 2019-08-23 16:12:51 PDT
Created attachment 377173 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-24 10:38:50 PDT
Comment on attachment 377173 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-08-24 11:21:10 PDT
Comment on attachment 377173 [details]
Patch

Clearing flags on attachment: 377173

Committed r249089: <https://trac.webkit.org/changeset/249089>
Comment 4 WebKit Commit Bot 2019-08-24 11:21:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-24 11:22:20 PDT
<rdar://problem/54673898>