Bug 201095

Summary: Web Inspector: "Copy Rule" menu item does not propagate comments properly
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Joseph Pecoraro
Reported 2019-08-23 15:25:53 PDT
"Copy Rule" menu item does not propagate comments properly Steps to Reproduce: 1. Inspect <body> on about:blank 2. Add some properties 3. Disable some properties 4. Click Rule Icon > Copy Rule 5. Paste => Disabled "commented out" properties are not commented out
Attachments
Patch (7.27 KB, patch)
2019-08-23 16:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-08-23 16:12:51 PDT
Created attachment 377173 [details] Patch
Joseph Pecoraro
Comment 2 2019-08-24 10:38:50 PDT
Comment on attachment 377173 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-08-24 11:21:10 PDT
Comment on attachment 377173 [details] Patch Clearing flags on attachment: 377173 Committed r249089: <https://trac.webkit.org/changeset/249089>
WebKit Commit Bot
Comment 4 2019-08-24 11:21:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-24 11:22:20 PDT
<rdar://problem/54673898>
Note You need to log in before you can comment on or make changes to this bug.