Bug 201092
| Summary: | Move foldQuoteMarks and foldQuoteMark out of TextIterator | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin, wenson_hsieh |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wenson Hsieh
…foldQuoteMarks isn’t specific to TextIterator; after https://webkit.org/b/201085, it should really be moved to a common utility file. That said, I’m unsure where the best home for this would be. WTFString.h? Perhaps StringCommon.h? Or maybe a new private header in WebCore? 🤔
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
One other consideration: I think that also the specific implementation we were using in TextIterator.cpp was scoped to just what we needed in *addition* to what's already done by usearch. Other call sites might eventually want something that would go beyond that.